Change exact match processor to match processor. #46041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Besides a rename, this changes allows to processor to attach multiple enrich docs to the document being ingested. Also in order to control the maximum number of enrich docs to be included in the document being ingested, the `max_matches` setting is added to the enrich processor. Relates elastic#32789
martijnvg
added
>non-issue
:Data Management/Ingest Node
|
Pinging @elastic/es-core-features |
|
@elasticmachine update branch |
hub-cap
approved these changes
Aug 28, 2019
| String matchField, | ||
| boolean ignoreMissing, | ||
| boolean overrideEnabled, | ||
| int maxMatches) { | ||
| this( | ||
| tag, | ||
| createSearchRunner(client), | ||
| policyName, | ||
| field, | ||
| targetField, | ||
| matchField, ignoreMissing, |
There was a problem hiding this comment.
not your change but it might be nice to put these on 2 lines too
| if (searchHits.length == 1) { | ||
| // If a document is returned, add its fields to the document | ||
| Map<String, Object> enrichDocument = searchHits[0].getSourceAsMap(); | ||
| ingestDocument.setFieldValue(targetField, enrichDocument); |
There was a problem hiding this comment.
Should this return the same structure (a list of maps) even with only 1 hit so the output is the same from the processor regardless of that field?
|
@elasticmachine run elasticsearch-ci/2 |
martijnvg
added a commit
that referenced
this pull request
Sep 4, 2019
Besides a rename, this changes allows to processor to attach multiple enrich docs to the document being ingested. Also in order to control the maximum number of enrich docs to be included in the document being ingested, the `max_matches` setting is added to the enrich processor. Relates #32789
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides a rename, this changes allows to processor to attach multiple
enrich docs to the document being ingested.
Also in order to control the maximum number of enrich docs to be
included in the document being ingested, the
max_matchessettingis added to the enrich processor.
Relates #32789