Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.8] Prevent deadlock by using separate schedulers (#48697) #48963

merged 2 commits into from Nov 12, 2019


Copy link

jakelandis commented Nov 11, 2019

Backports the following commits to 6.8:

  • Prevent deadlock by using separate schedulers (#48697)
Currently the BulkProcessor class uses a single scheduler to schedule
flushes and retries. Functionally these are very different concerns but
can result in a dead lock. Specifically, the single shared scheduler
can kick off a flush task, which only finishes it's task when the bulk
that is being flushed finishes. If (for what ever reason), any items in
that bulk fails it will (by default) schedule a retry. However, that retry
will never run it's task, since the flush task is consuming the 1 and
only thread available from the shared scheduler.

Since the BulkProcessor is mostly client based code, the client can
provide their own scheduler. As-is the scheduler would require
at minimum 2 worker threads to avoid the potential deadlock. Since the
number of threads is a configuration option in the scheduler, the code
can not enforce this 2 worker rule until runtime. For this reason this
commit splits the single task scheduler into 2 schedulers. This eliminates
the potential for the flush task to block the retry task and removes this
deadlock scenario.

This commit also deprecates the Java APIs that presume a single scheduler,
and updates any internal code to no longer use those APIs.

Fixes #47599

Note - #41451 fixed the general case where a bulk fails and is retried
that can result in a deadlock. This fix should address that case as well as
the case when a bulk failure *from the flush* needs to be retried.
@jakelandis jakelandis added the backport label Nov 11, 2019
@jakelandis jakelandis merged commit a0a484a into elastic:6.8 Nov 12, 2019
8 checks passed
8 checks passed
CLA All commits in pull request signed
elasticsearch-ci/1 Build finished.
elasticsearch-ci/2 Build finished.
elasticsearch-ci/bwc Build finished.
elasticsearch-ci/default-distro Build finished.
elasticsearch-ci/docs Build finished.
elasticsearch-ci/oss-distro-docs Build finished.
elasticsearch-ci/packaging-sample-matrix Build finished.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
1 participant
You can’t perform that action at this time.