Add index name to search requests #49175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't guarantee expected request failures if search request is across many indexes, as if expected shards fail, some indexes may return 200. closes elastic#47743
mayya-sharipova
added
the
:Search/Search
|
Pinging @elastic/es-search (:Search/Search) |
cbuescher
approved these changes
Nov 15, 2019
There was a problem hiding this comment.
Makes sense, LGTM!
I was suprised to see there is a possibility of other indices existing on these test clusters, thought they are wiped before runnig each of these tests, but apparently that doesn't go for dot-indices (at least there's one .ml in the test failure output, so thats good to know)
|
@cbuescher thanks. Indeed looks like system indexes exist on test clusters. |
mayya-sharipova
added a commit
that referenced
this pull request
Nov 15, 2019
We can't guarantee expected request failures if search request is across many indexes, as if expected shards fail, some indexes may return 200. closes #47743
mayya-sharipova
added a commit
that referenced
this pull request
Nov 15, 2019
We can't guarantee expected request failures if search request is across many indexes, as if expected shards fail, some indexes may return 200. closes #47743
jimczi
pushed a commit
to jimczi/elasticsearch
that referenced
this pull request
Nov 22, 2019
We can't guarantee expected request failures if search request is across many indexes, as if expected shards fail, some indexes may return 200. closes elastic#47743
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't guarantee expected request failures if search request is across
many indexes, as if expected shards fail, some indexes may return 200.
closes #47743