Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial EQL rest API stub #49768

Draft
wants to merge 1 commit into
base: feature/eql
from

Conversation

@aleksmaus
Copy link

aleksmaus commented Dec 2, 2019

It's my first PR, need a bit of feedback on the code shape and direction.
Specifically had to poke through RBACEngine.java and “mark” the request with CompositeIndicesRequest interface, not sure if this is the right approach.

@aleksmaus aleksmaus requested a review from costin Dec 2, 2019
@@ -212,6 +212,7 @@ private static boolean shouldAuthorizeIndexActionNameOnly(String action, Transpo
case "indices:data/write/reindex":
case "indices:data/read/sql":
case "indices:data/read/sql/translate":
case "indices:data/read/eql":

This comment has been minimized.

Copy link
@aleksmaus

aleksmaus Dec 2, 2019

Author

was not sure if there is a better approach instead of this ^

@aleksmaus aleksmaus added the WIP label Dec 2, 2019
@aleksmaus aleksmaus force-pushed the aleksmaus:feature/eql_rest branch from a91bdc3 to a89c7b3 Dec 2, 2019
@aleksmaus aleksmaus force-pushed the aleksmaus:feature/eql_rest branch from a32e29a to bcf861b Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.