Geo: Switch generated GeoJson type names to camel case (#50285)

[imotov]

Switches generated GeoJson type names to camel case
to conform to the standard.

Closes #49568

[elasticmachine]

Pinging @elastic/es-analytics-geo (:Analytics/Geo)

[talevy]

I think you meant GeoJson, not WKT?

[talevy]

this is for GeoJSON, not WKT. right?

these should all be capitalized using upper-camel-case/pascal-case

Circle, MultiLineString...

[imotov]

Indeed! Got carried away :)

[imotov]

@elasticmachine update branch

[imotov]

@elasticmachine update branch

[imotov]

@elasticmachine run elasticsearch-ci/2

[jennet]

Hi @imotov
I'm running ElasticSearch 7.16.0 but my geo_shapes are all being returned with lowercase type in their geojson data so I've been trying to find a workaround. This looks from the tags as if it should be fixed in version 7.6+, is that right?
Thanks!

[iverase]

Hi @jennet,

This is right, this change was done on 7.6.0 but it does not mean that you get all geojson not in camelcase. Let me explain.

Lets create an index an insert to points on with camel case and one without:

PUT test

PUT test/_mapping
{
      "properties" : {
        "location" : {
          "type" : "geo_shape"
        }
      }
}

POST /test/_doc
{
  "location": {
    "type" : "point",
    "coordinates" : [0,0]
  }
}

POST /test/_doc
{
  "location": {
    "type" : "Point",
    "coordinates" : [0,0]
  }
}

If you do a search without specifying how to retrieve the values, it returns the _source which is the original document, that is one point lowercase and the second one camel case:

GET test/_search 

{
  "took" : 6,
  "timed_out" : false,
  "_shards" : {
    "total" : 1,
    "successful" : 1,
    "skipped" : 0,
    "failed" : 0
  },
  "hits" : {
    "total" : {
      "value" : 2,
      "relation" : "eq"
    },
    "max_score" : 1.0,
    "hits" : [
      {
        "_index" : "test",
        "_id" : "IozZuH0BnP2_brwP3rs9",
        "_score" : 1.0,
        "_source" : {
          "location" : {
            "type" : "point",
            "coordinates" : [
              0,
              0
            ]
          }
        }
      },
      {
        "_index" : "test",
        "_id" : "I4zZuH0BnP2_brwP77sE",
        "_score" : 1.0,
        "_source" : {
          "location" : {
            "type" : "Point",
            "coordinates" : [
              0,
              0
            ]
          }
        }
      }
    ]
  }
}

One the other hand in 7.16 you can use the fields parameter in the request bodyto return data formatted in geojson. In that case both points are camel case:

GET test/_search 
{
  "_source": false, 
  "fields": [
    "location"
  ]
}

{
  "took" : 4,
  "timed_out" : false,
  "_shards" : {
    "total" : 1,
    "successful" : 1,
    "skipped" : 0,
    "failed" : 0
  },
  "hits" : {
    "total" : {
      "value" : 2,
      "relation" : "eq"
    },
    "max_score" : 1.0,
    "hits" : [
      {
        "_index" : "test",
        "_id" : "IozZuH0BnP2_brwP3rs9",
        "_score" : 1.0,
        "fields" : {
          "location" : [
            {
              "coordinates" : [
                0.0,
                0.0
              ],
              "type" : "Point"
            }
          ]
        }
      },
      {
        "_index" : "test",
        "_id" : "I4zZuH0BnP2_brwP77sE",
        "_score" : 1.0,
        "fields" : {
          "location" : [
            {
              "coordinates" : [
                0.0,
                0.0
              ],
              "type" : "Point"
            }
          ]
        }
      }
    ]
  }
}

Hope this helps.