New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating NodesInfo API to use plugins instead of singular plugin #5072

Merged
merged 1 commit into from Feb 11, 2014

Conversation

Projects
None yet
4 participants
@spinscale
Member

spinscale commented Feb 10, 2014

In order to be consistent (and because in 1.0 we switched from
parameter driven information to specifzing the metrics as part of the URI)
this patch moves from 'plugin' to 'plugins' in the Nodes Info API.

Important: This breaks BWC for 1.0 a bit more than the switch already done, but is now documented in the migration document as well.

@dadoonet

This comment has been minimized.

Member

dadoonet commented Feb 10, 2014

Left a minor comment. LGTM.

@s1monw

This comment has been minimized.

Contributor

s1monw commented Feb 10, 2014

LGTM

Migrating NodesInfo API to use plugins instead of singular plugin
In order to be consistent (and because in 1.0 we switched from
parameter driven information to specifzing the metrics as part of the URI)
this patch moves from 'plugin' to 'plugins' in the Nodes Info API.

@spinscale spinscale merged commit b02e6dc into elastic:master Feb 11, 2014

@spinscale spinscale self-assigned this Feb 11, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment