Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generated benchmark files to gitignore #51000

Merged
merged 2 commits into from Jan 14, 2020

Conversation

@gwbrown
Copy link
Contributor

gwbrown commented Jan 14, 2020

When building IntelliJ generates several source files related to the
benchmarks. This commit adds that path to the gitignore so these don't
get accidentally committed.

When building IntelliJ generates several source files related to the
benchmarks. This commit adds that path to the gitignore so these don't
get accidentally committed.
@elasticmachine

This comment has been minimized.

Copy link
Collaborator

elasticmachine commented Jan 14, 2020

Pinging @elastic/es-core-infra (:Core/Infra/Core)

@gwbrown

This comment has been minimized.

Copy link
Contributor Author

gwbrown commented Jan 14, 2020

@elasticmachine update branch

Copy link
Contributor

mark-vieira left a comment

LGTM

Copy link
Member

jaymode left a comment

LGTM

@gwbrown gwbrown merged commit 0296203 into elastic:master Jan 14, 2020
9 checks passed
9 checks passed
CLA All commits in pull request signed
Details
elasticsearch-ci/1 Build finished.
Details
elasticsearch-ci/2 Build finished.
Details
elasticsearch-ci/bwc Build finished.
Details
elasticsearch-ci/default-distro Build finished.
Details
elasticsearch-ci/docs Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample-matrix-unix Build finished.
Details
elasticsearch-ci/packaging-sample-matrix-windows Build finished.
Details
gwbrown added a commit that referenced this pull request Jan 14, 2020
When building IntelliJ generates several source files related to the
benchmarks. This commit adds that path to the gitignore so these don't
get accidentally committed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.