Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report progress of multiple plugin installs #51001

Merged

Conversation

@jasontedor
Copy link
Member

jasontedor commented Jan 14, 2020

When installing multiple plugins at once, this commit changes the behavior to report installed plugins as we go. In the case of failure, we emit a message that we are rolling back any plugins that were installed successfully, and also that they were successfully rolled back. In the case a plugin is not successfully rolled back, we report this clearly too, alerting the user that there might still be state on disk they would have to clean up.

Relates #50924

When installing multiple plugins at once, this commit changes the
behavior to report installed plugins as we go. In the case of failure,
we emit a message that we are rolling back any plugins that were
installed successfully, and also that they were successfully rolled
back. In the case a plugin is not successfully rolled back, we report
this clearly too, alerting the user that there might still be state on
disk they would have to clean up.
@elasticmachine

This comment has been minimized.

Copy link
Collaborator

elasticmachine commented Jan 14, 2020

Pinging @elastic/es-core-infra (:Core/Infra/Plugins)

Copy link
Member

rjernst left a comment

LGTM. Thank you!

@jasontedor jasontedor merged commit 514135d into elastic:master Jan 14, 2020
9 checks passed
9 checks passed
CLA All commits in pull request signed
Details
elasticsearch-ci/1 Build finished.
Details
elasticsearch-ci/2 Build finished.
Details
elasticsearch-ci/bwc Build finished.
Details
elasticsearch-ci/default-distro Build finished.
Details
elasticsearch-ci/docs Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample-matrix-unix Build finished.
Details
elasticsearch-ci/packaging-sample-matrix-windows Build finished.
Details
@jasontedor jasontedor deleted the jasontedor:multiple-plugin-install-progress branch Jan 14, 2020
jasontedor added a commit that referenced this pull request Jan 14, 2020
When installing multiple plugins at once, this commit changes the
behavior to report installed plugins as we go. In the case of failure,
we emit a message that we are rolling back any plugins that were
installed successfully, and also that they were successfully rolled
back. In the case a plugin is not successfully rolled back, we report
this clearly too, alerting the user that there might still be state on
disk they would have to clean up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.