Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL: document the use of a filter on _routing #52355

Merged
merged 3 commits into from Feb 14, 2020

Conversation

@astefan
Copy link
Contributor

astefan commented Feb 14, 2020

Added a TIP for searching using a routing key, since the routing URL parameter is not supported in SQL.
Also, polished some sections of the documentation (especially the functions ones) to fix the Description's way of being displayed.

- Added a TIP for searching using a routing key.
@elasticmachine

This comment has been minimized.

Copy link
Collaborator

elasticmachine commented Feb 14, 2020

Pinging @elastic/es-docs (>docs)

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

elasticmachine commented Feb 14, 2020

Pinging @elastic/es-search (:Search/SQL)

@astefan

This comment has been minimized.

@astefan astefan requested review from matriv, costin and bpintea Feb 14, 2020
@astefan astefan marked this pull request as ready for review Feb 14, 2020
Copy link
Contributor

matriv left a comment

LGTM. Nice find and addition with the _routing
From a quick look I couldn't see any change in the resulting HTML regarding the description changes, what am I missing?

@astefan

This comment has been minimized.

Copy link
Contributor Author

astefan commented Feb 14, 2020

LGTM. Nice find and addition with the _routing
From a quick look I couldn't see any change in the resulting HTML regarding the description changes, what am I missing?

@matriv

image
VS.
image

@bpintea

This comment has been minimized.

Copy link
Contributor

bpintea commented Feb 14, 2020

what am I missing?

the space introduced between Description: and following text.

@matriv
matriv approved these changes Feb 14, 2020
Copy link
Contributor

matriv left a comment

LGTM, I guess we could backport it to 7.6 as well?

@astefan astefan added the v7.6.1 label Feb 14, 2020
@astefan astefan merged commit 9fad0b1 into elastic:master Feb 14, 2020
4 checks passed
4 checks passed
CLA All commits passed the check
Details
elasticsearch-ci/docs Build finished.
Details
elasticsearch-ci/docs-check Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
@astefan astefan deleted the astefan:sql_docs_polishing branch Feb 14, 2020
astefan added a commit to astefan/elasticsearch that referenced this pull request Feb 14, 2020
* Fix "Description"s for various sections in the functions pages.
* Added a TIP for searching using a routing key.
* Other small polishings

(cherry picked from commit 9fad0b1)
astefan added a commit that referenced this pull request Feb 14, 2020
* Fix "Description"s for various sections in the functions pages.
* Added a TIP for searching using a routing key.
* Other small polishings

(cherry picked from commit 9fad0b1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.