New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke postCollection on aggregation collectors #5387

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@martijnvg
Member

martijnvg commented Mar 11, 2014

Also cleanup how facet and aggs collector are used inside the QueryCollector

@martijnvg martijnvg added bug labels Mar 11, 2014

@markharwood

This comment has been minimized.

Show comment
Hide comment
@markharwood

markharwood Mar 13, 2014

Contributor

The PercolatorFacetsAndAggregationsTests class with this PR applied works fine on the development branch for aggs where calling Aggregator.postCollection() is critical and was failing previously. Thanks, @martijnvg .

Contributor

markharwood commented Mar 13, 2014

The PercolatorFacetsAndAggregationsTests class with this PR applied works fine on the development branch for aggs where calling Aggregator.postCollection() is critical and was failing previously. Thanks, @martijnvg .

Invoke postCollection on aggregation collectors.
Also cleanup how facet and aggs collector are used inside the QueryCollector

Closes #5387

@martijnvg martijnvg closed this in aecadfc Mar 13, 2014

martijnvg added a commit that referenced this pull request Mar 13, 2014

Invoke postCollection on aggregation collectors.
Also cleanup how facet and aggs collector are used inside the QueryCollector

Closes #5387

martijnvg added a commit that referenced this pull request Mar 13, 2014

Invoke postCollection on aggregation collectors.
Also cleanup how facet and aggs collector are used inside the QueryCollector

Closes #5387

@martijnvg martijnvg deleted the martijnvg:bug/percolator-aggregation-postCollect branch May 18, 2015

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015

Invoke postCollection on aggregation collectors.
Also cleanup how facet and aggs collector are used inside the QueryCollector

Closes elastic#5387
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment