Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exceptions to GeoPointFieldMapper #5403

Closed
wants to merge 1 commit into from

Conversation

@chilling
Copy link
Contributor

commented Mar 12, 2014

Add exceptions to GeoPointFieldMapper when parsing geo_point object
Closes #5390

@s1monw

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2014

I think this looks great can you maybe add a testcase for it to make sure it's triggered?

@chilling

This comment has been minimized.

Copy link
Contributor Author

commented Mar 19, 2014

@s1monw, @jpountz I refactored the GeoPoint and GeoPointFieldMapper to use a common method for parsing

@jpountz
jpountz reviewed Mar 19, 2014
View changes
src/main/java/org/elasticsearch/common/geo/GeoUtils.java Outdated
} else {
return point.resetFromGeoHash(geohash);
}
} else if (Double.isInfinite(lat)) {

This comment has been minimized.

Copy link
@jpountz

jpountz Mar 19, 2014

Contributor

s/isInfinite/isNaN/

This comment has been minimized.

Copy link
@chilling

chilling Mar 19, 2014

Author Contributor

thx. fixed it

@jpountz

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2014

+1 to push

* moved `geo_point` parsing to GeoUtils
* cleaned up `gzipped.json` for bulktest
* merged `GeoPointFieldMapper` and `GeoPoint` parsing methods

Closes #5390
@chilling

This comment has been minimized.

Copy link
Contributor Author

commented Mar 19, 2014

pushed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.