New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count latch down if sendsPing throws exception #5440

Merged
merged 1 commit into from Mar 16, 2014

Conversation

Projects
None yet
3 participants
@s1monw
Contributor

s1monw commented Mar 16, 2014

if the async sendPingsHandler throws an unexpected exception the
corresponding latch is never counted down. This might only happen
during node shutdown but can still cause starvation or test failures.

@kimchy

This comment has been minimized.

Show comment
Hide comment
@kimchy

kimchy Mar 16, 2014

Member

LGTM

Member

kimchy commented Mar 16, 2014

LGTM

@s1monw s1monw added bug labels Mar 16, 2014

Count latch down if sendsPing throws exception
if the async sendPingsHandler throws an unexpected exception the
corresponding latch is never counted down. This might only happen
during node shutdown but can still cause starvation or test failures.

@s1monw s1monw merged commit 43617cf into elastic:master Mar 16, 2014

@s1monw s1monw deleted the s1monw:sends_ping branch Mar 24, 2014

@s1monw

This comment has been minimized.

Show comment
Hide comment
@s1monw

s1monw Mar 24, 2014

Contributor

this is also on 1.x & 1.1, 1.0.2, 0.90.13

Contributor

s1monw commented Mar 24, 2014

this is also on 1.x & 1.1, 1.0.2, 0.90.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment