Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible discrepancy in circuit breaker in parent/child #5526

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
3 participants
@martijnvg
Copy link
Member

commented Mar 25, 2014

Set the actual bytes used in circuit breaker back to how it was before loading if the loading wasn't successful.

@s1monw

View changes

src/main/java/org/elasticsearch/index/fielddata/plain/ParentChildIndexFieldData.java Outdated
@@ -144,6 +144,8 @@ public ParentChildAtomicFieldData loadDirect(AtomicReaderContext context) throws
}
if (success) {

This comment has been minimized.

Copy link
@s1monw

s1monw Mar 25, 2014

Contributor

should this happen in yet another try / finally or do you want to close the builders in a way that they can't throw an exception?

@s1monw

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2014

I left a comment @martijnvg

martijnvg added some commits Mar 25, 2014

Set the actual bytes used in circuit breaker back to how it was befor…
…e loading if the loading wasn't successful.
@martijnvg

This comment has been minimized.

Copy link
Member Author

commented Mar 25, 2014

@s1monw I added a commit.

@s1monw

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2014

LGTM

martijnvg added a commit that referenced this pull request Mar 25, 2014

Set the actual bytes used in circuit breaker back to how it was befor…
…e loading if the loading wasn't successful.

Closes #5526

@martijnvg martijnvg closed this in a48254a Mar 25, 2014

@martijnvg martijnvg added bug and removed bug labels Mar 25, 2014

martijnvg added a commit that referenced this pull request Mar 25, 2014

Set the actual bytes used in circuit breaker back to how it was befor…
…e loading if the loading wasn't successful.

Closes #5526

@martijnvg martijnvg deleted the martijnvg:bug/pc-breaker branch May 18, 2015

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.