Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST API: Removed support for aliases as part of index settings #5545

Merged
merged 1 commit into from Aug 1, 2014

Conversation

Projects
None yet
4 participants
@javanna
Copy link
Member

commented Mar 26, 2014

Now that we have explicit support for aliases when creating indices and as part of index templates, we may remove support for aliases (only names) as part of index settings. The change is marked as breaking as the following calls:

curl -XPUT localhost:9200/index -d '{
  "settings" : {
    "aliases" : [ "alias1"]
  }
}

and

curl -XPUT localhost:9200/index -d '{
  "settings" : {
    "index.aliases" : [ "alias1"]
  }
}

won't be supported anymore and will need to be replaced with

curl -XPUT localhost:9200/index -d '{
  "aliases" : {
    "alias1": {}
  }
}

@javanna javanna added v2.0.0 labels Mar 26, 2014

@javanna javanna self-assigned this Mar 26, 2014

@kimchy

This comment has been minimized.

Copy link
Member

commented Apr 11, 2014

LGTM, I wonder if this can be back ported to 1.x as well, since we stopped communicating setting based alias creation since 0.90

@javanna

This comment has been minimized.

Copy link
Member Author

commented Apr 17, 2014

+1 for backporting as the alias as part of settings feature was quite hidden and not promoted. Would be interesting to know how many users rely on it and would need to change their code due to this change.

@clintongormley

This comment has been minimized.

Copy link
Member

commented Jul 4, 2014

@javanna this should be merged, no?

@javanna

This comment has been minimized.

Copy link
Member Author

commented Jul 9, 2014

hey @clintongormley yes it should be merged, we just have to decide whether we want to backport it to 1.x too or not...

@javanna javanna added the v1.3.0 label Jul 11, 2014

@s1monw s1monw added v1.4.0 and removed v1.3.0 labels Jul 14, 2014

Removed support for aliases as part of index settings
Now that we have explicit support for aliases when creating indices and as part of index templates, we may remove support for aliases (only names) as part of index settings. This is partially breaking as the following calls:

curl -XPUT localhost:9200/index -d '{
  "settings" : {
    "aliases" : [ "alias1"]
  }
}

and

curl -XPUT localhost:9200/index -d '{
  "settings" : {
    "index.aliases" : [ "alias1"]
  }
}

were previously supported and will need to be replaced with

curl -XPUT localhost:9200/index -d '{
  "aliases" : {
    "alias1": {}
  }
}

Closes #5545

@javanna javanna merged commit d5b6de3 into elastic:master Aug 1, 2014

javanna added a commit that referenced this pull request Aug 1, 2014

Removed support for aliases as part of index settings
Now that we have explicit support for aliases when creating indices and as part of index templates, we may remove support for aliases (only names) as part of index settings. This is partially breaking as the following calls:

curl -XPUT localhost:9200/index -d '{
  "settings" : {
    "aliases" : [ "alias1"]
  }
}

and

curl -XPUT localhost:9200/index -d '{
  "settings" : {
    "index.aliases" : [ "alias1"]
  }
}

were previously supported and will need to be replaced with

curl -XPUT localhost:9200/index -d '{
  "aliases" : {
    "alias1": {}
  }
}

Closes #5545

javanna added a commit that referenced this pull request Sep 8, 2014

Removed support for aliases as part of index settings
Now that we have explicit support for aliases when creating indices and as part of index templates, we may remove support for aliases (only names) as part of index settings. This is partially breaking as the following calls:

curl -XPUT localhost:9200/index -d '{
  "settings" : {
    "aliases" : [ "alias1"]
  }
}

and

curl -XPUT localhost:9200/index -d '{
  "settings" : {
    "index.aliases" : [ "alias1"]
  }
}

were previously supported and will need to be replaced with

curl -XPUT localhost:9200/index -d '{
  "aliases" : {
    "alias1": {}
  }
}

Closes #5545

@clintongormley clintongormley changed the title Removed support for aliases as part of index settings REST API: Removed support for aliases as part of index settings Sep 9, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.