New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cluster name to state #5624

Merged
merged 2 commits into from Mar 31, 2014

Conversation

Projects
None yet
3 participants
@s1monw
Contributor

s1monw commented Mar 31, 2014

see #5622

@kimchy

View changes

src/main/java/org/elasticsearch/cluster/ClusterState.java Outdated
@@ -430,6 +437,7 @@ public static Builder builder(ClusterState state) {
public static class Builder {
private ClusterName clusterName;

This comment has been minimized.

@kimchy

kimchy Mar 31, 2014

Member

should we make this final then? Also, in the Builder(ClusterState state) constructor, we should copy over the cluster state from the provided state.

@kimchy

This comment has been minimized.

Member

kimchy commented Mar 31, 2014

left one comment, other than that, LGTM

@s1monw

This comment has been minimized.

Contributor

s1monw commented Mar 31, 2014

man good catch... I pushed a new commit.

@kimchy

This comment has been minimized.

Member

kimchy commented Mar 31, 2014

LGTM

s1monw added some commits Mar 31, 2014

Add cluster_name to cluster_state
Today the clusterstate is not asssociated with the cluster_name which is odd
since it's pretty much it's only valid identifier. Any node can send a cluster
state to another node today even if it's not the same cluster. These situations
can happen rarely during tests or even in the wild by accident.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment