Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lucene LMSimilarity #5701

Closed
wants to merge 1 commit into from

Conversation

@kzwang
Copy link
Contributor

commented Apr 7, 2014

closes #5697

@javanna
javanna reviewed Apr 7, 2014
View changes
docs/reference/index-modules/similarity.asciidoc Outdated
Jelinek Mercer similarity] . This similarity has the following options:

[horizontal]
`lamba`:: The optimal value depends on both the collection and the query. The optimal value is around `0.1`

This comment has been minimized.

Copy link
@javanna

javanna Apr 7, 2014

Member

this is a typo right? should be lambda I think.

This comment has been minimized.

Copy link
@kzwang

kzwang Apr 7, 2014

Author Contributor

oh... yes it's a typo

@javanna javanna self-assigned this Apr 7, 2014
@jpountz

This comment has been minimized.

Copy link
Contributor

commented Apr 7, 2014

Apart from the typo that Luca found, this looks good to me!

@kzwang

This comment has been minimized.

Copy link
Contributor Author

commented Apr 7, 2014

@javanna @jpountz fixed the typo

@@ -0,0 +1,36 @@
package org.elasticsearch.index.similarity;

This comment has been minimized.

Copy link
@javanna

javanna Apr 7, 2014

Member

We are missing the license header here... build fails :(

@@ -0,0 +1,36 @@
package org.elasticsearch.index.similarity;

This comment has been minimized.

Copy link
@javanna

javanna Apr 7, 2014

Member

Same as above

@kzwang

This comment has been minimized.

Copy link
Contributor Author

commented Apr 7, 2014

@javanna added license header

@javanna

This comment has been minimized.

Copy link
Member

commented Apr 7, 2014

Merged, thanks!

@javanna javanna closed this Apr 7, 2014
@clintongormley clintongormley changed the title add lucene LMSimilarity Add lucene LMSimilarity Jun 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.