New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid unnecessary use of stored_fields in our docs. #57488
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtibshirani
added
>docs
General docs changes
:Search/Search
Search-related issues that do not fall into other categories
:Core/Infra/Scripting
Scripting abstractions, Painless, and Mustache
v8.0.0
v6.8.0
v7.7.0
v7.8.0
v7.9.0
labels
Jun 1, 2020
Pinging @elastic/es-docs (>docs) |
Pinging @elastic/es-search (:Search/Search) |
Pinging @elastic/es-core-infra (:Core/Infra/Scripting) |
jtibshirani
force-pushed
the
stored-fields-docs
branch
2 times, most recently
from
June 1, 2020 22:58
7a35d1f
to
4941d19
Compare
jtibshirani
force-pushed
the
stored-fields-docs
branch
from
June 1, 2020 23:02
4941d19
to
647321a
Compare
rjernst
approved these changes
Jun 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jtibshirani
added a commit
that referenced
this pull request
Jun 2, 2020
Generally we don't advocate for using `stored_fields`, and we're interested in eventually removing the need for this parameter. So it's best to avoid using stored fields in our docs examples when it's not actually necessary. Individual changes: * Avoid using 'stored_fields' in our docs. * When defining script fields in top-hits, de-emphasize stored fields.
jtibshirani
added a commit
that referenced
this pull request
Jun 2, 2020
Generally we don't advocate for using `stored_fields`, and we're interested in eventually removing the need for this parameter. So it's best to avoid using stored fields in our docs examples when it's not actually necessary. Individual changes: * Avoid using 'stored_fields' in our docs. * When defining script fields in top-hits, de-emphasize stored fields.
jtibshirani
added a commit
that referenced
this pull request
Jun 2, 2020
Generally we don't advocate for using `stored_fields`, and we're interested in eventually removing the need for this parameter. So it's best to avoid using stored fields in our docs examples when it's not actually necessary. Individual changes: * Avoid using 'stored_fields' in our docs. * When defining script fields in top-hits, de-emphasize stored fields.
Hailei
pushed a commit
to Hailei/elasticsearch
that referenced
this pull request
Jun 3, 2020
Generally we don't advocate for using `stored_fields`, and we're interested in eventually removing the need for this parameter. So it's best to avoid using stored fields in our docs examples when it's not actually necessary. Individual changes: * Avoid using 'stored_fields' in our docs. * When defining script fields in top-hits, de-emphasize stored fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Core/Infra/Scripting
Scripting abstractions, Painless, and Mustache
>docs
General docs changes
:Search/Search
Search-related issues that do not fall into other categories
Team:Core/Infra
Meta label for core/infra team
Team:Docs
Meta label for docs team
Team:Search
Meta label for search team
v6.8.0
v7.7.0
v7.8.0
v7.9.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally we don't advocate for using
stored_fields
, and we're interested ineventually removing the need for this parameter. So it's best to avoid using
stored fields in our docs examples when it's not actually necessary.
Individual changes: