Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly quote $JAVA in bin/plugin #5765

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@dieswaytoofast
Copy link
Contributor

dieswaytoofast commented Apr 10, 2014

The all new Oracle Java 7 on OSX has
JAVA_HOME=/Library/Internet Plug-Ins/JavaAppletPlugin.plugin/Contents/Home
Note the happy space in "Internet Plug-Ins" - it gives plugin
major agida...

Protect $JAVA from the crazy spaces in OSX
The all new Oracle Java 7 on OSX keeps $JAVA has
JAVA_HOME=/Library/Internet Plug-Ins/JavaAppletPlugin.plugin/Contents/Home
Note the happy space in "Internet Plug-Ins" - it gives plugin
major agida...

@spinscale spinscale self-assigned this Apr 14, 2014

@spinscale

This comment has been minimized.

Copy link
Member

spinscale commented Apr 14, 2014

Uh. Very valid PR. Can you sign the CLA, so I can get it in? See http://www.elasticsearch.org/contributor-agreement/

@dieswaytoofast

This comment has been minimized.

Copy link
Contributor Author

dieswaytoofast commented Apr 14, 2014

done

@spinscale spinscale changed the title Protect $JAVA from the crazy spaces in OSX Plugin Manager: Properly quote $JAVA in bin/plugin Jul 18, 2014

@spinscale spinscale added the bug label Jul 18, 2014

@spinscale spinscale closed this in 4eca049 Jul 18, 2014

spinscale added a commit that referenced this pull request Jul 18, 2014

Plugin Manager: Properly quote $JAVA in bin/plugin
The all new Oracle Java 7 on OSX has a space in its path
resulting in bin/plugin failing to work

Closes #5765

spinscale added a commit that referenced this pull request Jul 18, 2014

Plugin Manager: Properly quote $JAVA in bin/plugin
The all new Oracle Java 7 on OSX has a space in its path
resulting in bin/plugin failing to work

Closes #5765

@clintongormley clintongormley changed the title Plugin Manager: Properly quote $JAVA in bin/plugin Plugins: Properly quote $JAVA in bin/plugin Sep 9, 2014

@clintongormley clintongormley changed the title Plugins: Properly quote $JAVA in bin/plugin Properly quote $JAVA in bin/plugin Jun 7, 2015

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015

Plugin Manager: Properly quote $JAVA in bin/plugin
The all new Oracle Java 7 on OSX has a space in its path
resulting in bin/plugin failing to work

Closes elastic#5765
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.