Don't log on RetentionLeaseSync error handler after an index has been deleted #58098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After an index has been deleted it may take some time to cancel all the maintenance tasks such as RetentionLeaseSync, it's possible that the task is already executing before the cancellation. This commit just avoids logging a warning message for those scenarios. Closes elastic#57864
fcofdez
added
>enhancement
:Distributed/Engine
|
Pinging @elastic/es-distributed (:Distributed/Engine) |
dnhatn
approved these changes
Jun 15, 2020
fcofdez
added a commit
to fcofdez/elasticsearch
that referenced
this pull request
Jun 16, 2020
After an index has been deleted it may take some time to cancel all the maintenance tasks such as RetentionLeaseSync, it's possible that the task is already executing before the cancellation. This commit just avoids logging a warning message for those scenarios. Closes elastic#57864
fcofdez
added a commit
to fcofdez/elasticsearch
that referenced
this pull request
Jun 16, 2020
After an index has been deleted it may take some time to cancel all the maintenance tasks such as RetentionLeaseSync, it's possible that the task is already executing before the cancellation. This commit just avoids logging a warning message for those scenarios. Closes elastic#57864 Backport of (elastic#58098)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After an index has been deleted it may take some time to cancel all the
maintenance tasks such as RetentionLeaseSync, it's possible that the
task is already executing before the cancellation. This commit just
avoids logging a warning message for those scenarios.
Closes #57864