Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instantiate facets/aggregations during the QUERY phase. #5821

Closed

Conversation

@jpountz
Copy link
Contributor

commented Apr 15, 2014

In case of a DFS_QUERY_THEN_FETCH request, facets and aggregations are currently
instantiated during the DFS phase while they only become useful during the QUERY
phase. By instantiating during the QUERY phase instead, we can make better use
of recycling since objects will have a shorter life out of the recyclers.

jpountz added 2 commits Apr 15, 2014
…ase.

Today, if some shards pass the DFS phase but all of them fail the QUERY phase,
the response will only consist of failed shards. We should throw an exception
instead in order to be consistent with the QUERY_THEN_FETCH type.
In case of a DFS_QUERY_THEN_FETCH request, facets and aggregations are currently
instantiated during the DFS phase while they only become useful during the QUERY
phase. By instantiating during the QUERY phase instead, we can make better use
of recycling since objects will have a shorter life out of the recyclers.
@s1monw

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2014

++

@jpountz jpountz self-assigned this Apr 15, 2014
@jpountz jpountz added v1.2.0 labels Apr 15, 2014
jpountz added a commit that referenced this pull request Apr 24, 2014
In case of a DFS_QUERY_THEN_FETCH request, facets and aggregations are currently
instantiated during the DFS phase while they only become useful during the QUERY
phase. By instantiating during the QUERY phase instead, we can make better use
of recycling since objects will have a shorter life out of the recyclers.

Close #5821
@jpountz jpountz closed this in d792d14 Apr 24, 2014
@jpountz jpountz deleted the jpountz:fix/create_aggregators_on_query_phase branch Apr 24, 2014
@jpountz jpountz added the enhancement label Apr 24, 2014
mikemccand added a commit to mikemccand/elasticsearch that referenced this pull request Apr 24, 2014
In case of a DFS_QUERY_THEN_FETCH request, facets and aggregations are currently
instantiated during the DFS phase while they only become useful during the QUERY
phase. By instantiating during the QUERY phase instead, we can make better use
of recycling since objects will have a shorter life out of the recyclers.

Close elastic#5821
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.