Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to change concurrent merge scheduling setting dynamically #6098

Closed

Conversation

@kimchy
Copy link
Member

commented May 8, 2014

Allow to change the concurrent merge scheduler settings dynamically using the update settings API

Allow to change the concurrent merge scheduler settings dynamically using the update settings API
@kimchy kimchy added review labels May 8, 2014
@mikemccand

This comment has been minimized.

Copy link
Contributor

commented May 8, 2014

The changes look fine, except we have no test coverage in Lucene verifying these live settings changes take effect / don't cause deadlock / whatnot. I know Rob is looking at randomizing this in the test infra, so we'll get some limited "first do no harm" coverage with that.

@mikemccand

This comment has been minimized.

Copy link
Contributor

commented May 8, 2014

I committed a test case to Lucene to confirm live changes to maxMergeCount take effect: http://svn.apache.org/r1593380 ... seems to be passing! Testing maxThreadCount is trickier ...

@kimchy kimchy closed this in 78e3988 May 12, 2014
kimchy added a commit that referenced this pull request May 12, 2014
Allow to change the concurrent merge scheduler settings dynamically using the update settings API
closes #6098
@javanna javanna added the enhancement label May 14, 2014
@s1monw s1monw removed the review label Jun 18, 2014
@kimchy kimchy deleted the kimchy:dynamic_setting_merge_scheduler branch Aug 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.