Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Percolator: Fix assertion in percolation with nested docs #6263

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
3 participants
@brwe
Copy link
Contributor

brwe commented May 21, 2014

Assertion was triggered for percolating documents with nested object
in mapping if the document did not actually contain a nested object.
Instead, in this case we can just use the SingleDocumentPercolatorIndex.

Fix assertion in percolation with nested docs
Assertion was triggered for percolating documents with nested object
in mapping if the document did not actually contain a nested object.
Instead, in this case we can just use the SingleDocumentPercolatorIndex.

@brwe brwe added bug labels May 21, 2014

@s1monw

This comment has been minimized.

Copy link
Contributor

s1monw commented May 21, 2014

LGTM

@brwe brwe added the v1.1.2 label May 21, 2014

@brwe

This comment has been minimized.

Copy link
Contributor Author

brwe commented May 21, 2014

Pushed to 1.2, 1.x and master. Should I also backport to 1.1 branch?

@brwe brwe closed this in 8cca9b2 May 21, 2014

brwe added a commit that referenced this pull request May 21, 2014

Percolator: Fix assertion in percolation with nested docs
Assertion was triggered for percolating documents with nested object
in mapping if the document did not actually contain a nested object.
Reason:
MultiDocumentPercolatorIndex checks if the number of documents is
actualu >1. Instead we can just use the SingleDocumentPercolatorIndex
in this case.

closes #6263

brwe added a commit that referenced this pull request May 21, 2014

Percolator: Fix assertion in percolation with nested docs
Assertion was triggered for percolating documents with nested object
in mapping if the document did not actually contain a nested object.
Reason:
MultiDocumentPercolatorIndex checks if the number of documents is
actualu >1. Instead we can just use the SingleDocumentPercolatorIndex
in this case.

closes #6263

brwe added a commit that referenced this pull request May 22, 2014

Percolator: Fix assertion in percolation with nested docs
Assertion was triggered for percolating documents with nested object
in mapping if the document did not actually contain a nested object.
Reason:
MultiDocumentPercolatorIndex checks if the number of documents is
actualu >1. Instead we can just use the SingleDocumentPercolatorIndex
in this case.

closes #6263

@brwe brwe changed the title Fix assertion in percolation with nested docs Percolator: Fix assertion in percolation with nested docs May 27, 2014

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015

Percolator: Fix assertion in percolation with nested docs
Assertion was triggered for percolating documents with nested object
in mapping if the document did not actually contain a nested object.
Reason:
MultiDocumentPercolatorIndex checks if the number of documents is
actualu >1. Instead we can just use the SingleDocumentPercolatorIndex
in this case.

closes elastic#6263

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015

Percolator: Fix assertion in percolation with nested docs
Assertion was triggered for percolating documents with nested object
in mapping if the document did not actually contain a nested object.
Reason:
MultiDocumentPercolatorIndex checks if the number of documents is
actualu >1. Instead we can just use the SingleDocumentPercolatorIndex
in this case.

closes elastic#6263
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.