Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added syntax for single item specification. #6311

Closed

Conversation

Projects
None yet
3 participants
@alexksikes
Copy link
Contributor

commented May 26, 2014

Users are more likely to search for only one document than for multiple ones.
This commit extends the current syntax with 'id' and 'doc' for single item
search. Additionally, 'ids' and 'docs' now support a single value or a single
object respectively. For consitency with 'like_text', alternative syntax such
as 'like_doc', 'like_docs', 'like_id' and 'like_ids' are also possible.

More This Like Query: Added syntax for single item specification.
Users are more likely to search for only one document than for multiple ones.
This commit extends the current syntax with 'id' and 'doc' for single item
search. Additionally, 'ids' and 'docs' now support a single value or a single
object respectively. For consitency with 'like_text', alternative syntax such
as 'like_doc', 'like_docs', 'like_id' and 'like_ids' are also possible.
@s1monw

This comment has been minimized.

Copy link
Contributor

commented Jun 26, 2014

I don't think we should really go the gazillion different ways to say X way. I'd rather only have one single way to say it. I mean what is wrong with having a docs list with only one value?

@s1monw s1monw removed the review label Jun 26, 2014

@clintongormley

This comment has been minimized.

Copy link
Member

commented Jul 1, 2014

++ keep it simple

@clintongormley

This comment has been minimized.

Copy link
Member

commented Aug 22, 2014

Hi @alexksikes

Where are you on this PR? Are you redoing it? Have you abandoned it? If so please close

@alexksikes

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2014

This will be part of a more advanced item specification syntax. Closing for now.

@alexksikes alexksikes closed this Aug 23, 2014

@clintongormley clintongormley changed the title More This Like Query: Added syntax for single item specification. More Like This Query: Added syntax for single item specification. Sep 11, 2014

@clintongormley clintongormley changed the title More Like This Query: Added syntax for single item specification. Added syntax for single item specification. Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.