Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object and Type parsing: Fix include_in_all in type #6353

Closed
wants to merge 1 commit into from

Conversation

@brwe
Copy link
Contributor

commented May 30, 2014

include_in_all can also be set on type level (root object).
This fixes a regression introduced in #6093

closes #6304

include_in_all can also be set on type level (root object).
This fixes a regression introduced  in #6093

closes #6304
@s1monw

This comment has been minimized.

Copy link
Contributor

commented Jun 2, 2014

the fix looks good but I wonder if you want add a test for the other cases we can set this?

@brwe

This comment has been minimized.

Copy link
Contributor Author

commented Jun 2, 2014

SimpleAllMapperTests already has some tests that cover that, for example testMultiField_includeInAllSetToFalse(). Do you still think we need another one?

@s1monw

This comment has been minimized.

Copy link
Contributor

commented Jun 2, 2014

no in that case I think I am good.... LGTM

@brwe

This comment has been minimized.

Copy link
Contributor Author

commented Jun 2, 2014

ok, pushed to master (125e0c1), 1.2 (34d6200) and 1.x (dafba2e)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.