EQL: Wrap a verification_exception in an index_not_found_exception in case there is no valid index available #64212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in an index_not_found_exception providing also the original index pattern that may be lost in the chain of filters involving the Security one.
Collaborator
|
Pinging @elastic/es-ql (:Query Languages/EQL) |
elasticmachine
added
the
Team:QL (Deprecated)
costin
reviewed
Oct 27, 2020
| @Override | ||
| public void onFailure(Exception e) { | ||
| Exception finalException = e; | ||
| if (e instanceof IndexNotFoundException) { |
Member
There was a problem hiding this comment.
Would be good to add a comment on why this is needed.
costin
reviewed
Oct 27, 2020
|
|
||
| public LogicalPlan preAnalyze(LogicalPlan plan, IndexResolution indices) { | ||
| // wrap a potential index_not_found_exception with a VerificationException (expected by client) | ||
| if (indices.isValid() == false) { |
Member
There was a problem hiding this comment.
A comment is useful to indicate why the Verification exception is wrapped inside an infe
Contributor
Author
|
@elasticmachine update branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In scenarios where Security is enabled in the cluster, a wildcard defined index pattern that gets resolved in a no-index result loses the original pattern and the error message contains a
*, -*instead. This change wraps the original verification_exception that gets thrown while checking for valid indices in a index_not_found_exception in the REST layer (where also the original index pattern is available). The provided tests show the actual error messages that get thrown in different scenarios (with/without Security, with/without a wildcard index pattern, existent/inexistent index).Fixes #63529.