Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a blocking variant of close() method to BulkProcessor #6586

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
6 participants
@matt-preston
Copy link
Contributor

matt-preston commented Jun 22, 2014

Blocks until all bulk requests have completed.

Updated based on feedback
Updated formatting

Closes #4158
Closes #6314

Implementation of blocking close method
Blocks until all bulk requests have completed.  This fixes #4158
@s1monw

This comment has been minimized.

Copy link
Contributor

s1monw commented Jul 17, 2014

@matt-preston I wonder if you can sign the CLA so I can pull this in?

@s1monw

This comment has been minimized.

Copy link
Contributor

s1monw commented Jul 17, 2014

@matt-preston nevermind I overlooked your CLA - it's on file...

@s1monw s1monw assigned s1monw and unassigned javanna Jul 17, 2014

@s1monw s1monw removed the review label Jul 17, 2014

@s1monw

This comment has been minimized.

Copy link
Contributor

s1monw commented Jul 17, 2014

I merged it in - thanks...

@s1monw s1monw closed this Jul 17, 2014

@clintongormley clintongormley changed the title [Updated] Implementation of blocking close method #4180 Java API: Add a blocking variant of close() method to BulkProcessor Sep 10, 2014

@yeroc

This comment has been minimized.

Copy link

yeroc commented Sep 24, 2014

I'm curious why the new awaitClose() method doesn't take a org.elasticsearch.common.unit.TimeValue as this is used elsewhere in the ElasticSearch API where timeouts are specified?

@clintongormley clintongormley changed the title Java API: Add a blocking variant of close() method to BulkProcessor Add a blocking variant of close() method to BulkProcessor Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.