If the node initialisation fails, make sure the node environment is closed correctly #6715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…losed correctly (and thus all locks being properly released)
|
this looks good though. Can you sign the CLA so I can pull this in? |
|
@gnodet can you sign the CLA otherwise I can't pull this in sorry. |
|
Done, sorry, I missed the first comment |
s1monw
pushed a commit
that referenced
this pull request
Jul 9, 2014
If the node initialisation fails, make sure the node environment is closed correctly and thus all locks (on data directories) being properly released. Closes #6715
|
pushed thanks, I fixed the commit msg a bit hence the PR is not marked as |
clintongormley
changed the title
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... (and thus all locks being properly released)