SQL: Fix ZonedDateTime with nanos serialisation #68253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the `ConstantProcessor` was using the `[read/write]GenericValue` for ZonedDateTime which is implemented in `StreamInput` and doesn't read/write the nanos resolution of the objects. Implment custom serialisation to include the nanos. Follows: elastic#67666
elasticmachine
added
the
Team:QL (Deprecated)
|
Pinging @elastic/es-ql (Team:QL) |
alyokaz
pushed a commit
to alyokaz/elasticsearch
that referenced
this pull request
Mar 10, 2021
Previously the `ConstantProcessor` was using the `[read/write]GenericValue` for ZonedDateTime which is implemented in `StreamInput` and doesn't read/write the nanos resolution of the objects. Implement custom serialisation to include the nanos. Follows: elastic#67666
easyice
pushed a commit
to easyice/elasticsearch
that referenced
this pull request
Mar 25, 2021
Previously the `ConstantProcessor` was using the `[read/write]GenericValue` for ZonedDateTime which is implemented in `StreamInput` and doesn't read/write the nanos resolution of the objects. Implement custom serialisation to include the nanos. Follows: elastic#67666
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the
ConstantProcessorwas using the[read/write]GenericValuefor ZonedDateTime which is implemented inStreamInputand doesn't read/write the nanos resolution of theobjects. Implement custom serialisation to include the nanos.
Follows: #67666