New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove (mostly) unused 'failure' member from ShardSearchFailure. #6861

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@rjernst
Member

rjernst commented Jul 14, 2014

closes #6837

@rjernst rjernst added v1.4.0 labels Jul 15, 2014

@s1monw

This comment has been minimized.

Show comment
Hide comment
@s1monw

s1monw Jul 15, 2014

Contributor

this looks good to me - I wonder what @kimchy thinks

Contributor

s1monw commented Jul 15, 2014

this looks good to me - I wonder what @kimchy thinks

@s1monw s1monw removed the review label Jul 15, 2014

@kimchy

This comment has been minimized.

Show comment
Hide comment
@kimchy

kimchy Jul 23, 2014

Member

LGTM

Member

kimchy commented Jul 23, 2014

LGTM

@clintongormley

This comment has been minimized.

Show comment
Hide comment
@clintongormley

clintongormley Aug 7, 2014

Member

@rjernst want to get this merged in?

Member

clintongormley commented Aug 7, 2014

@rjernst want to get this merged in?

@rjernst

This comment has been minimized.

Show comment
Hide comment
@rjernst

rjernst Aug 7, 2014

Member

Yes, will do so shortly.

Member

rjernst commented Aug 7, 2014

Yes, will do so shortly.

@rjernst rjernst added enhancement and removed bug labels Aug 7, 2014

@rjernst rjernst closed this in 90d2cb7 Aug 7, 2014

rjernst added a commit that referenced this pull request Aug 7, 2014

rjernst added a commit that referenced this pull request Sep 8, 2014

@clintongormley clintongormley changed the title from Remove (mostly) unused 'failure' member from ShardSearchFailure. to Internal: Remove (mostly) unused 'failure' member from ShardSearchFailure. Sep 8, 2014

@rjernst rjernst deleted the rjernst:fix/6837 branch Jan 21, 2015

@clintongormley clintongormley changed the title from Internal: Remove (mostly) unused 'failure' member from ShardSearchFailure. to Remove (mostly) unused 'failure' member from ShardSearchFailure. Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment