Reintroduce JNA Fallocate Wrapper #68858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Second go at #68687 now using the proper indirection so that this works on both OSX and Linux. We can't use the same class we use for `mlock` like the original PR did because the method signature differs across OSX and Linux.
original-brownbear
added
>non-issue
:Distributed Coordination/Snapshot/Restore
elasticmachine
added
the
Team:Distributed (Obsolete)
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
joegallo
reviewed
Feb 10, 2021
server/src/main/java/org/elasticsearch/bootstrap/JNAFalloc.java
Outdated
Show resolved
Hide resolved
Contributor
|
https://github.com/elastic/elasticsearch/compare/7a4011dc868..f93003a11bd is a handy link for reviewing this, it drops the diff from #68687 out so you only see the "new" diff that's the osx fix. |
joegallo
approved these changes
Feb 10, 2021
Contributor
joegallo
left a comment
joegallo
left a comment
There was a problem hiding this comment.
LGTM and works on my machine. ❤️
Contributor
Author
|
Thanks for the speedy revert + review on this one Joe! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second go at #68687 now using the proper indirection so that this works
on both OSX and Linux. We can't use the same class we use for
mlocklike the original PR didbecause the method signature differs across OSX and Linux.
Apart from the indirection in
JNAFallocthis is unchanged from the previous PR.