Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename FieldMapper.termsFilter to fieldDataTermsFilter. #6888

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@jpountz
Copy link
Contributor

jpountz commented Jul 16, 2014

FieldMapper has two methods
Filter termsFilter(List values, @Nullable QueryParseContext) which is supposed
to work on the inverted index and
Filter termsFilter(QueryParseContext, List, QueryParseContext) which is
supposed to work on field data. Let's rename the second one to
fieldDataTermsFilter and remove the unused QueryParseContext.

Refactoring: Rename FieldMapper.termsFilter to fieldDataTermsFilter.
FieldMapper has two methods
`Filter termsFilter(List values, @nullable QueryParseContext)` which is supposed
to work on the inverted index and
`Filter termsFilter(QueryParseContext, List, QueryParseContext)` which is
supposed to work on field data. Let's rename the second one to
`fieldDataTermsFilter` and remove the unused `QueryParseContext`.

@jpountz jpountz added the review label Jul 16, 2014

@s1monw

This comment has been minimized.

Copy link
Contributor

s1monw commented Jul 17, 2014

LGTM

@jpountz jpountz closed this in 9714dd5 Jul 17, 2014

jpountz added a commit that referenced this pull request Jul 17, 2014

Refactoring: Rename FieldMapper.termsFilter to fieldDataTermsFilter.
FieldMapper has two methods
`Filter termsFilter(List values, @nullable QueryParseContext)` which is supposed
to work on the inverted index and
`Filter termsFilter(QueryParseContext, List, QueryParseContext)` which is
supposed to work on field data. Let's rename the second one to
`fieldDataTermsFilter` and remove the unused `QueryParseContext`.

Close #6888

@jpountz jpountz added v2.0.0 and removed review labels Jul 17, 2014

@jpountz jpountz deleted the jpountz:fix/field_data_terms_filter branch Jul 17, 2014

@jpountz jpountz added breaking and removed breaking labels Jul 21, 2014

@clintongormley clintongormley changed the title Refactoring: Rename FieldMapper.termsFilter to fieldDataTermsFilter. Internal: Rename FieldMapper.termsFilter to fieldDataTermsFilter. Sep 8, 2014

@clintongormley clintongormley changed the title Internal: Rename FieldMapper.termsFilter to fieldDataTermsFilter. Rename FieldMapper.termsFilter to fieldDataTermsFilter. Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.