Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In top_hits agg, when parent doc is found stop iterating over segments and continue with the next top matching child doc #6895

Merged

Conversation

Projects
None yet
4 participants
@martijnvg
Copy link
Member

martijnvg commented Jul 16, 2014

The parent doc has been found and there is no need to check subsequent segments.

Relates to #1843

@jpountz

This comment has been minimized.

Copy link
Contributor

jpountz commented Jul 16, 2014

LGTM

Query: When parent doc is found stop iterating over segments and cont…
…inue with the next top matching child doc.

The parent doc has been found and there is no need to check subsequent segments.

Closes #6895
Closes #1843

@martijnvg martijnvg merged commit ca7fa4f into elastic:master Jul 16, 2014

martijnvg added a commit that referenced this pull request Jul 16, 2014

Query: When parent doc is found stop iterating over segments and cont…
…inue with the next top matching child doc.

The parent doc has been found and there is no need to check subsequent segments.

Closes #6895
Closes #1843

@clintongormley clintongormley changed the title Query: When parent doc is found stop iterating over segments and continue with the next top matching child doc Parent/Child: When parent doc is found stop iterating over segments and continue with the next top matching child doc Sep 8, 2014

@clintongormley clintongormley changed the title Parent/Child: When parent doc is found stop iterating over segments and continue with the next top matching child doc Parent/Child: In top_hits agg, when parent doc is found stop iterating over segments and continue with the next top matching child doc Oct 3, 2014

@martijnvg martijnvg deleted the martijnvg:improvements/top_children_skipper branch May 18, 2015

@clintongormley clintongormley changed the title Parent/Child: In top_hits agg, when parent doc is found stop iterating over segments and continue with the next top matching child doc In top_hits agg, when parent doc is found stop iterating over segments and continue with the next top matching child doc Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.