Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ScoreAccessor utility class publicly available for other script engines #6898

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@rjernst
Copy link
Member

commented Jul 16, 2014

With the removal of setNextScore in #6864, script engines must use
the Scorer to find the score of a document. The DocLookup is updated
appropriately to do this, but most script engines require a Number to be
bound for numeric variables. Groovy already had an encapsulation for
this funtionality, and this moves it out to be shared with other script
engines.

Scripts: Make ScoreAccessor utility class plublicly available for oth…
…er script

engines to use.

With the removal of setNextScore in #6864, script engines must use
the Scorer to find the score of a document.  The DocLookup is updated
appropriately to do this, but most script engines require a Number to be
bound for numeric variables.  Groovy already had an encapsulation for
this funtionality, and this moves it out to be shared with other script
engines.
@rmuir

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2014

looks good

@rjernst rjernst closed this in 7139f44 Jul 16, 2014

@rjernst rjernst deleted the rjernst:refactor/score-accessor branch Jul 16, 2014

rjernst added a commit that referenced this pull request Jul 17, 2014

Scripts: Make ScoreAccessor utility available for other script engines.
With the removal of setNextScore in #6864, script engines must use
the Scorer to find the score of a document.  The DocLookup is updated
appropriately to do this, but most script engines require a Number to be
bound for numeric variables.  Groovy already had an encapsulation for
this funtionality, and this moves it out to be shared with other script
engines.

closes #6898

@rjernst rjernst added v1.4.0 labels Jul 23, 2014

@clintongormley clintongormley changed the title Scripts: Make ScoreAccessor utility class plublicly available for other script engines Scripting: Make ScoreAccessor utility class plublicly available for other script engines Sep 8, 2014

@clintongormley clintongormley changed the title Scripting: Make ScoreAccessor utility class plublicly available for other script engines Make ScoreAccessor utility class publicly available for other script engines Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.