-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch fielddata to use Lucene doc values APIs. #6908
Closed
Closed
Commits on Jul 18, 2014
-
Fielddata: Switch to Lucene DV APIs.
This commits removes BytesValues/LongValues/DoubleValues/... and tries to use Lucene's APIs such as NumericDocValues or RandomAccessOrds instead whenever possible. The next step would be to take advantage of the fact that APIs are the same in Lucene and Elasticsearch in order to remove our custom comparators and use Lucene's. There are a few side-effects to this change: - GeoDistanceComparator has been removed, DoubleValuesComparator is used instead on top of dynamically computed values (was easier than migrating GeoDistanceComparator). - SortedNumericDocValues doesn't guarantee uniqueness so long/double terms aggregators have been updated to make sure a document cannot fall twice in the same bucket. - Sorting by maximum value of a field or running a `max` aggregation is potentially significantly faster thanks to the random-access API. Our aggs and p/c aggregations benchmarks don't report differences with this change on uninverted field data. However the fact that doc values don't need to be wrapped anymore seems to help a lot. For example TermsAggregationSearchBenchmark reports ~30% faster terms aggregations on doc values on string fields with this change, which are now only ~18% slower than uninverted field data although stored on disk.
11Configuration menu - View commit details
-
Copy full SHA for 8f45f46 - Browse repository at this point
Copy the full SHA 8f45f46View commit details -
Configuration menu - View commit details
-
Copy full SHA for 47ad575 - Browse repository at this point
Copy the full SHA 47ad575View commit details -
Configuration menu - View commit details
-
Copy full SHA for 03a3e4a - Browse repository at this point
Copy the full SHA 03a3e4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3528cc2 - Browse repository at this point
Copy the full SHA 3528cc2View commit details
Commits on Jul 21, 2014
-
Have an internal MurmurHash3Values class instead of reusing SortedNum…
…ericDocValues since order is not guaranteed.
Configuration menu - View commit details
-
Copy full SHA for 2094bca - Browse repository at this point
Copy the full SHA 2094bcaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 14f82a1 - Browse repository at this point
Copy the full SHA 14f82a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4809047 - Browse repository at this point
Copy the full SHA 4809047View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7084de0 - Browse repository at this point
Copy the full SHA 7084de0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c2c14c - Browse repository at this point
Copy the full SHA 7c2c14cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.