Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better message for invalid internal transport message format #6916

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@kimchy
Copy link
Member

kimchy commented Jul 18, 2014

No description provided.

@kimchy kimchy added review and removed v2.0.0 labels Jul 18, 2014

+ Integer.toHexString(buffer.getByte(readerIndex) & 0xFF) + ","
+ Integer.toHexString(buffer.getByte(readerIndex + 1) & 0xFF) + ","
+ Integer.toHexString(buffer.getByte(readerIndex + 2) & 0xFF) + ","
+ Integer.toHexString(buffer.getByte(readerIndex + 3) & 0xFF) + ")");

This comment has been minimized.

Copy link
@dakrone

dakrone Jul 18, 2014

Member

Can you add the text " expected 'ES'" (or the correct hex) to the exception?

@jpountz

This comment has been minimized.

Copy link
Contributor

jpountz commented Jul 18, 2014

LGTM

@dakrone

View changes

src/main/java/org/elasticsearch/transport/netty/SizeHeaderFrameDecoder.java Outdated
@@ -19,6 +19,7 @@

package org.elasticsearch.transport.netty;

import org.apache.lucene.util.BytesRef;

This comment has been minimized.

Copy link
@dakrone

dakrone Jul 18, 2014

Member

Unneeded import that got added?

@kimchy kimchy added v1.4.0 and removed v1.3.0 labels Jul 18, 2014

kimchy added a commit that referenced this pull request Jul 18, 2014

kimchy added a commit that referenced this pull request Jul 18, 2014

@kimchy

This comment has been minimized.

Copy link
Member Author

kimchy commented Jul 18, 2014

closed

@kimchy kimchy closed this Jul 18, 2014

@kimchy kimchy deleted the kimchy:better_stream_corrupt_message branch Jul 18, 2014

@jpountz jpountz removed the review label Jul 24, 2014

@clintongormley clintongormley changed the title Better message for invalid internal transport message format Internal: Better message for invalid internal transport message format Sep 8, 2014

@clintongormley clintongormley changed the title Internal: Better message for invalid internal transport message format Better message for invalid internal transport message format Jun 7, 2015

@lcawl lcawl added :Core/Infra/Core and removed :Exceptions labels Feb 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.