Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded cluster state serialization during cluster join #6949

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@bleskes
Copy link
Member

bleskes commented Jul 21, 2014

At the moment we serialize the cluster state in JoinResponse and ValidateJoinRequest. However this state is not used anywhere and can be removed to save on network overhead

[Discovery] remove unneeded cluster state serialization during cluste…
…r join process

At the moment we serialize the cluster state in JoinResponse and ValidateJoinRequest. However this state is not used anywhere and can be removed to save on network overhead

@bleskes bleskes added v2.0.0 labels Jul 21, 2014

@kimchy

This comment has been minimized.

Copy link
Member

kimchy commented Jul 21, 2014

LGTM

@bleskes bleskes closed this in 690820d Jul 21, 2014

bleskes added a commit that referenced this pull request Jul 21, 2014

[Discovery] remove unneeded cluster state serialization during cluste…
…r join process

At the moment we serialize the cluster state in JoinResponse and ValidateJoinRequest. However this state is not used anywhere and can be removed to save on network overhead

Closes #6949

@bleskes bleskes deleted the bleskes:join_without_cluster_state branch Jul 21, 2014

bleskes added a commit that referenced this pull request Jul 21, 2014

[Discovery] fix MembershipAction.sendJoinRequestBlocking should now e…
…xpect an empty response

The change introduced in #6949 (do not serialize the cluster state) also means master now responds with an empty response rather then a JoinResponse. However, sendJoinRequestBlocking still expected a JoinRequest.

bleskes added a commit that referenced this pull request Jul 21, 2014

[Discovery] fix MembershipAction.sendJoinRequestBlocking should now e…
…xpect an empty response

The change introduced in #6949 (do not serialize the cluster state) also means master now responds with an empty response rather then a JoinResponse. However, sendJoinRequestBlocking still expected a JoinRequest.

@jpountz jpountz removed the review label Jul 24, 2014

@clintongormley clintongormley changed the title [Discovery] remove unneeded cluster state serialization during cluster join Resiliency: Remove unneeded cluster state serialization during cluster join Sep 8, 2014

@clintongormley clintongormley changed the title Resiliency: Remove unneeded cluster state serialization during cluster join Internal: Remove unneeded cluster state serialization during cluster join Sep 8, 2014

@clintongormley clintongormley changed the title Internal: Remove unneeded cluster state serialization during cluster join Remove unneeded cluster state serialization during cluster join Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.