Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable loading of bloom filters by default #6959

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
4 participants
@mikemccand
Copy link
Contributor

mikemccand commented Jul 22, 2014

This commit changes the default for index.codec.bloom.load to false,
because bloom filters can use a sizable amount of RAM on indices with
many tiny documents, and now only gives smallish index-time
performance gains for apps that update (not just append) documents,
since we've separately improved performance for ID lookups with
#6298.

Closes #6349

Core: disable loading of bloom filters by default
This commit changes the default for index.codec.bloom.load to false,
because bloom filters can use a sizable amount of RAM on indices with
many tiny documents, and now only gives smallish index-time
performance gains for apps that update (not just append) documents,
since we've separately improved performance for ID lookups with
#6298.

Closes #6349

@mikemccand mikemccand added v1.4.0 and removed enhancement labels Jul 22, 2014

@s1monw

This comment has been minimized.

Copy link
Contributor

s1monw commented Jul 22, 2014

can we randomly set this setting for the index in ElasticsearchIntegrationTest#setRandomSettings other than that it looks good

@s1monw s1monw removed the review label Jul 22, 2014

@mikemccand

This comment has been minimized.

Copy link
Contributor Author

mikemccand commented Jul 22, 2014

OK I added randomization for loading bloom filters or not ...

@s1monw

This comment has been minimized.

Copy link
Contributor

s1monw commented Jul 23, 2014

LGTM

@s1monw s1monw removed the review label Jul 23, 2014

mikemccand added a commit that referenced this pull request Jul 23, 2014

Core: don't load bloom filters by default
This change just changes the default for index.codec.bloom.load to
false: with recent performance improvements to ID lookup, such as
#6298, bloom filters don't give much of a performance gain anymore,
and they can consume non-trivial RAM when there are many tiny
documents.

For now, we still index the bloom filters, so if a given app wants
them back, it can just update the index.codec.bloom.load to true.

Closes #6959
@bobrik

This comment has been minimized.

Copy link
Contributor

bobrik commented Jul 27, 2014

Looking at diff, PUT /old_index/_settings?index.codec.bloom.load=false doesn't look right. I think it should be true in docs now.

@mikemccand

This comment has been minimized.

Copy link
Contributor Author

mikemccand commented Jul 27, 2014

Thanks @bobrik I just fixed this.

@clintongormley clintongormley changed the title Core: disable loading of bloom filters by default Indexing: disable loading of bloom filters by default Sep 8, 2014

@clintongormley clintongormley changed the title Indexing: disable loading of bloom filters by default Indexing: Disable loading of bloom filters by default Sep 8, 2014

@cfeio cfeio referenced this pull request Feb 9, 2015

Closed

Update no_more_bloom version #267

@clintongormley clintongormley changed the title Indexing: Disable loading of bloom filters by default Disable loading of bloom filters by default Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.