Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the `_name` parameter to the `simple_query_string` query #6979

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@dakrone
Copy link
Member

commented Jul 23, 2014

No description provided.

@jpountz

This comment has been minimized.

Copy link
Contributor

commented Jul 28, 2014

LGTM

@jpountz jpountz removed the review label Jul 28, 2014

@martijnvg

This comment has been minimized.

Copy link
Member

commented Jul 28, 2014

LGTM

@martijnvg

This comment has been minimized.

Copy link
Member

commented Jul 28, 2014

maybe should be backported to the 1.3 branch as well?

@dakrone

This comment has been minimized.

Copy link
Member Author

commented Jul 28, 2014

maybe should be backported to the 1.3 branch as well?

Is not supporting the _name feature a bug though, or just a missing feature?

@martijnvg

This comment has been minimized.

Copy link
Member

commented Jul 28, 2014

I lean towards a bug, since any query/filter should support since it named queries has been introduced.

@s1monw

This comment has been minimized.

Copy link
Contributor

commented Jul 28, 2014

yeah I think this can go into 1.3.2

@dakrone dakrone added the v1.3.2 label Jul 29, 2014

@dakrone

This comment has been minimized.

Copy link
Member Author

commented Jul 29, 2014

Merged into 1.3, 1.x, and master.

@dakrone dakrone closed this Jul 29, 2014

@clintongormley clintongormley changed the title Add support for the `_name` parameter to the simple_query_string query Query DSL: Add support for the `_name` parameter to the `simple_query_string` query Sep 8, 2014

@dakrone dakrone deleted the dakrone:add-sqs-name branch Sep 9, 2014

@clintongormley clintongormley changed the title Query DSL: Add support for the `_name` parameter to the `simple_query_string` query Add support for the `_name` parameter to the `simple_query_string` query Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.