Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor TransportActions #6989

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@GaelTadh
Copy link
Contributor

commented Jul 23, 2014

Get rid of boilerplate code for handling transport actions.
Make these transport actions extend HandledTransportAction where this code
now lives.

[REFACTOR] TransportActions
Get rid of boilerplate code for handling transport actions.
Make these transport actions extend HandledTransportAction where this code
now lives.
@kimchy

This comment has been minimized.

Copy link
Member

commented Jul 23, 2014

LGTM, should be tagger 1.4 as well, right?

@javanna

This comment has been minimized.

Copy link
Member

commented Jul 23, 2014

I like this a lot! In fact when you introduced the HandledTransportAction I wondered why you didn't use it all over the place ;)
We might be able to do the same in some other places I think, like for instance TransportIndexReplicationOperationAction and probably others? I would try and go over all the transport actions and see whether we can do the same, I think it can go on 1.4 too without bw comp problems.

@GaelTadh GaelTadh added the v1.4.0 label Jul 23, 2014

@s1monw

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2014

I love the stats!! LGTM

@s1monw s1monw removed the review label Jul 23, 2014

@GaelTadh GaelTadh closed this Jul 24, 2014

@GaelTadh

This comment has been minimized.

Copy link
Contributor Author

commented Jul 24, 2014

@javanna I'll do the others in a separate change.

@clintongormley clintongormley changed the title [REFACTOR] TransportActions Internal: Refactor TransportActions Sep 8, 2014

@clintongormley clintongormley changed the title Internal: Refactor TransportActions Refactor TransportActions Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.