Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Remove HttpClient to only use one HTTP client implementation #7003

Merged
merged 1 commit into from Jul 25, 2014

Conversation

Projects
None yet
3 participants
@spinscale
Copy link
Member

spinscale commented Jul 24, 2014

The HTTP client implementation used by the Elasticsearch REST tests is
backed by apache http client instead of a self written helper class,
that uses HttpUrlConnection. This commit removes the old simple HttpClient
class used for some plugin tests and uses the more powerful and reliable one for all tests.

It also fixes a minor bug, that when sending a 301 redirect, a Location
header needs to be added as well, which was uncovered by the switching
to the new client.

@spinscale spinscale added the review label Jul 24, 2014

@s1monw

This comment has been minimized.

Copy link
Contributor

s1monw commented Jul 24, 2014

LGTM

@s1monw s1monw removed the review label Jul 24, 2014

Tests: Remove HttpClient to only use one Http client
The HTTP client implementation used by the Elasticsearch REST tests is
backed by apache http client instead of a self written helper class,
that uses HttpUrlConnection. This commit removes the old simple HttpClient
class and uses the more powerful and reliable one for all tests.

It also fixes a minor bug, that when sending a 301 redirect, a Location
header needs to be added as well, which was uncovered by the switching
to the new client.

Closes #7003

@spinscale spinscale merged commit 35e5623 into elastic:master Jul 25, 2014

spinscale added a commit that referenced this pull request Jul 25, 2014

Tests: Remove HttpClient to only use one Http client
The HTTP client implementation used by the Elasticsearch REST tests is
backed by apache http client instead of a self written helper class,
that uses HttpUrlConnection. This commit removes the old simple HttpClient
class and uses the more powerful and reliable one for all tests.

It also fixes a minor bug, that when sending a 301 redirect, a Location
header needs to be added as well, which was uncovered by the switching
to the new client.

Closes #7003

@clintongormley clintongormley changed the title Tests: Remove HttpClient to only use one HTTP client implementation Test: Remove HttpClient to only use one HTTP client implementation Sep 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.