Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up string sort with custom missing value #7005

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@rmuir
Copy link
Contributor

rmuir commented Jul 24, 2014

Today if the user supplies a custom missing value for a string sort, we do it in an extremely slow way, not using ordinals but dereferencing bytes for every document. Ordinals are only used if the missing value is _first or _last.

Instead, use ordinals with custom missing values too.

@rmuir rmuir added v2.0.0 labels Jul 24, 2014

@s1monw

This comment has been minimized.

Copy link
Contributor

s1monw commented Jul 24, 2014

LGTM

1 similar comment
@jpountz

This comment has been minimized.

Copy link
Contributor

jpountz commented Jul 24, 2014

LGTM

@rmuir rmuir closed this in d8cd755 Jul 24, 2014

rmuir added a commit that referenced this pull request Jul 24, 2014

Speed up string sort with custom missing value
Today if the user supplies a custom missing value for a string sort,
we do it in an extremely slow way, not using ordinals but dereferencing
bytes for every document. Ordinals are only used if the missing value
is _first or _last.

Instead, use ordinals with custom missing values too.

Closes #7005

@rmuir rmuir changed the title Speed up string sort with custom missing value Sorting: Speed up string sort with custom missing value Jul 29, 2014

@jpountz jpountz removed the review label Jul 29, 2014

@clintongormley clintongormley changed the title Sorting: Speed up string sort with custom missing value Speed up string sort with custom missing value Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.