Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of recycled set in filters eviction #7012

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@kimchy
Copy link
Member

kimchy commented Jul 24, 2014

No description provided.

@kimchy kimchy added review labels Jul 24, 2014

@kimchy kimchy added the enhancement label Jul 24, 2014

@jpountz

View changes

src/main/java/org/elasticsearch/indices/cache/filter/IndicesFilterCache.java Outdated
@@ -167,6 +166,8 @@ public void onRemoval(RemovalNotification<WeightedFilterCache.FilterCacheKey, Do
*/
class ReaderCleaner implements Runnable {

private final ObjectOpenHashSet<Object> keys = ObjectOpenHashSet.newInstance();

This comment has been minimized.

Copy link
@jpountz

jpountz Jul 24, 2014

Contributor

Is it thread-safe? If the cleanup takes very long I think this set might be used by two threads at the same time?

This comment has been minimized.

Copy link
@kimchy

kimchy Jul 24, 2014

Author Member

yea, another cleanup is never scheduled until the first one ends

This comment has been minimized.

Copy link
@jpountz

jpountz Jul 24, 2014

Contributor

Can you just leave a comment about it?

@jpountz

This comment has been minimized.

Copy link
Contributor

jpountz commented Jul 24, 2014

LGTM

@kimchy kimchy closed this in eb37a59 Jul 24, 2014

kimchy added a commit that referenced this pull request Jul 24, 2014

@jpountz jpountz removed the review label Jul 29, 2014

@kimchy kimchy deleted the kimchy:remove_recycler_set branch Aug 18, 2014

@clintongormley clintongormley changed the title remove use of recycled set in filters eviction Internal: Remove use of recycled set in filters eviction Sep 8, 2014

@clintongormley clintongormley changed the title Internal: Remove use of recycled set in filters eviction Remove use of recycled set in filters eviction Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.