Remove use of recycled set in filters eviction #7012

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@kimchy
elastic member

No description provided.

@kimchy kimchy added the enhancement label Jul 24, 2014
@jpountz jpountz and 1 other commented on an outdated diff Jul 24, 2014
...icsearch/indices/cache/filter/IndicesFilterCache.java
@@ -167,6 +166,8 @@ public void onRemoval(RemovalNotification<WeightedFilterCache.FilterCacheKey, Do
*/
class ReaderCleaner implements Runnable {
+ private final ObjectOpenHashSet<Object> keys = ObjectOpenHashSet.newInstance();
@jpountz
jpountz Jul 24, 2014

Is it thread-safe? If the cleanup takes very long I think this set might be used by two threads at the same time?

@kimchy
kimchy Jul 24, 2014

yea, another cleanup is never scheduled until the first one ends

@jpountz
jpountz Jul 24, 2014

Can you just leave a comment about it?

@jpountz
elastic member

LGTM

@kimchy kimchy added a commit that closed this pull request Jul 24, 2014
@kimchy kimchy remove use of recycled set in filters eviction
closes #7012
eb37a59
@kimchy kimchy closed this in eb37a59 Jul 24, 2014
@kimchy kimchy added a commit that referenced this pull request Jul 24, 2014
@kimchy kimchy remove use of recycled set in filters eviction
closes #7012
bd699ec
@jpountz jpountz removed the review label Jul 29, 2014
@kimchy kimchy deleted the kimchy:remove_recycler_set branch Aug 18, 2014
@lindstromhenrik lindstromhenrik added a commit to episerver/elasticsearch that referenced this pull request Aug 21, 2014
@kimchy kimchy remove use of recycled set in filters eviction
closes #7012
a4d2da4
@clintongormley clintongormley changed the title from remove use of recycled set in filters eviction to Internal: Remove use of recycled set in filters eviction Sep 8, 2014
@clintongormley clintongormley changed the title from Internal: Remove use of recycled set in filters eviction to Remove use of recycled set in filters eviction Jun 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment