Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce non-null settings. #7032

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@jpountz
Copy link
Contributor

jpountz commented Jul 25, 2014

Now that we are using the index created version to make index-time decisions,
assuming that the version is the current version when settings are null is
very error-prone. Instead we should ensure that settings are always non-null
and contain the version when the index was created.

Mappings: Enforce non-null settings.
No that we are using the index created version to make index-time decisions,
assuming that the version is the current version when settings are null is
very error-prone. Instead we should ensure that settings are always non-null
and contain the version when the index was created.

@jpountz jpountz added the review label Jul 25, 2014

@kimchy

This comment has been minimized.

Copy link
Member

kimchy commented Jul 25, 2014

LGTM

@jpountz jpountz added v2.0.0 and removed review labels Jul 25, 2014

@jpountz jpountz closed this in f682461 Jul 25, 2014

jpountz added a commit that referenced this pull request Jul 25, 2014

Mappings: Enforce non-null settings.
No that we are using the index created version to make index-time decisions,
assuming that the version is the current version when settings are null is
very error-prone. Instead we should ensure that settings are always non-null
and contain the version when the index was created.

Close #7032

@clintongormley clintongormley changed the title Mappings: Enforce non-null settings. Mapping: Enforce non-null settings. Sep 11, 2014

@clintongormley clintongormley changed the title Mapping: Enforce non-null settings. Enforce non-null settings. Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.