Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lucene version checker should use `Lucene.parseVersionLenient` #7056

Closed

Conversation

Projects
None yet
4 participants
@dadoonet
Copy link
Member

dadoonet commented Jul 28, 2014

With commit 07c632a, we now have a new Lucene.parseVersionLenient(String, Version) method which tries to find an existing Lucene version based on the two first digits X.Y of X.Y.Z String.

Plugin Lucene version checker: use `Lucene.parseVersionLenient`
With commit 07c632a, we now have a new Lucene.parseVersionLenient(String, Version) method which tries to find an existing Lucene version based on the two first digits X.Y of X.Y.Z String.

@dadoonet dadoonet self-assigned this Jul 28, 2014

@s1monw s1monw added v2.0.0 labels Jul 28, 2014

@s1monw

This comment has been minimized.

Copy link
Contributor

s1monw commented Jul 28, 2014

LGTM

@dadoonet dadoonet removed the review label Jul 28, 2014

@nik9000

This comment has been minimized.

Copy link
Contributor

nik9000 commented Jul 28, 2014

Cool.

@dadoonet

This comment has been minimized.

Copy link
Member Author

dadoonet commented Jul 28, 2014

Closed with 264d59c in master and c698ff7 in 1.x

@dadoonet dadoonet closed this Jul 28, 2014

@dadoonet dadoonet deleted the dadoonet:pr/plugin-version-parselenient branch Jul 28, 2014

@clintongormley clintongormley changed the title Plugin Lucene version checker: use `Lucene.parseVersionLenient` Plugins: Lucene version checker should use `Lucene.parseVersionLenient` Sep 8, 2014

@clintongormley clintongormley changed the title Plugins: Lucene version checker should use `Lucene.parseVersionLenient` Lucene version checker should use `Lucene.parseVersionLenient` Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.