Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stops direct subclassing of InternalNumericMetricsAggregation #7058

Closed

Conversation

Projects
None yet
3 participants
@colings86
Copy link
Member

colings86 commented Jul 28, 2014

Must subclass either InternalNumericMetricsAggregation.SingleValue or InternalNumericMetricsAggregation.MultiValue

Aggregations: Stops direct subclassing of InternalNumericMetricsAggre…
…gation

Must subclass either InternalNumericMetricsAggregation.SingleValue or InternalNumericMetricsAggregation.MultiValue

@colings86 colings86 added the review label Jul 28, 2014

@s1monw

This comment has been minimized.

Copy link
Contributor

s1monw commented Jul 28, 2014

LGTM

@colings86 colings86 added v1.4.0 and removed review labels Jul 28, 2014

@colings86 colings86 self-assigned this Jul 28, 2014

@colings86

This comment has been minimized.

Copy link
Member Author

colings86 commented Jul 28, 2014

Merged into master and 1.x

@colings86 colings86 closed this Jul 28, 2014

@colings86 colings86 assigned colings86 and unassigned colings86 Aug 21, 2014

@colings86 colings86 deleted the colings86:feature/metricsAggEnhancement branch Aug 21, 2014

@clintongormley clintongormley changed the title Aggregations: Stops direct subclassing of InternalNumericMetricsAggregat... Aggregations: Stops direct subclassing of InternalNumericMetricsAggregation Sep 8, 2014

@clintongormley clintongormley changed the title Aggregations: Stops direct subclassing of InternalNumericMetricsAggregation Stops direct subclassing of InternalNumericMetricsAggregation Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.