Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make `cluster.routing.allocation.allow_rebalance` a dynamic setting #7095

Merged
merged 1 commit into from Aug 5, 2014

Conversation

Projects
None yet
4 participants
@dakrone
Copy link
Member

dakrone commented Jul 30, 2014

Also makes it a static constant and changes all tests to use it instead
of a string.

Fixes #7092

@dakrone dakrone added review labels Jul 30, 2014

@kimchy

This comment has been minimized.

Copy link
Member

kimchy commented Aug 1, 2014

LGTM, can we have a generic static method on the enum to parse it from a string value, and share it between the code in the apply settings and the constructor?

@dakrone

This comment has been minimized.

Copy link
Member Author

dakrone commented Aug 1, 2014

@kimchy pushed another commit adding the static method

@kimchy

View changes

.../org/elasticsearch/cluster/routing/allocation/decider/ClusterRebalanceAllocationDecider.java Outdated
try {
newType = ClusterRebalanceType.parseString(newAllowRebalance);
} catch (ElasticsearchIllegalArgumentException e) {
// ignore, setting will not be changed

This comment has been minimized.

Copy link
@kimchy

kimchy Aug 1, 2014

Member

maybe log here? or even add a validator for it in the dynamic settings to prevent setting the wrong value?

This comment has been minimized.

Copy link
@dakrone

dakrone Aug 1, 2014

Author Member

Sounds good, I was mimicking the old behavior, but adding a log message would be better.

@dakrone

This comment has been minimized.

Copy link
Member Author

dakrone commented Aug 4, 2014

Pushed another commit to this that adds a custom Validator for the ClusterRebalanceAllocationDecider.

@kimchy

This comment has been minimized.

Copy link
Member

kimchy commented Aug 5, 2014

LGTM

Make "cluster.routing.allocation.allow_rebalance" a dynamic setting
Also makes it a static constant and changes all tests to use it instead
of a string.

Fixes #7092

@dakrone dakrone merged commit 8124bca into elastic:master Aug 5, 2014

@jpountz jpountz removed the review label Aug 11, 2014

@clintongormley clintongormley changed the title Make "cluster.routing.allocation.allow_rebalance" a dynamic setting Settings: Make "cluster.routing.allocation.allow_rebalance" a dynamic setting Sep 8, 2014

@dakrone dakrone deleted the dakrone:make-allow-relabance-dynamic branch Sep 9, 2014

@clintongormley clintongormley changed the title Settings: Make "cluster.routing.allocation.allow_rebalance" a dynamic setting Make `cluster.routing.allocation.allow_rebalance` a dynamic setting Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.