Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return found: false for docs requested between index and refresh #7124

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
4 participants
@alexksikes
Copy link
Contributor

commented Aug 1, 2014

Closes #7121

settings:
"index.translog.disable_flush": true
"index.number_of_shards": 1
"refresh_interval": "1h"

This comment has been minimized.

Copy link
@javanna

javanna Aug 1, 2014

Member

I'd disable refresh entirely (-1) just to make sure that the document is not found in the index.

@@ -0,0 +1,36 @@
setup:

This comment has been minimized.

Copy link
@javanna

javanna Aug 1, 2014

Member

can we name this file following the convention used with the other REST tests? something like 02_bla_bla.yaml or even add the test to the existing yaml file for term_vector?

@@ -170,7 +170,6 @@ public XContentBuilder toXContent(XContentBuilder builder, Params params) throws
builder.field(FieldStrings._VERSION, docVersion);
builder.field(FieldStrings.FOUND, isExists());
if (!isExists()) {
builder.endObject();

This comment has been minimized.

Copy link
@javanna

javanna Aug 1, 2014

Member

Was the additional endObject causing a bug? If it's not needed anymore it means it closed an object one too many times before this fix?

This comment has been minimized.

Copy link
@alexksikes

alexksikes Aug 1, 2014

Author Contributor

Yes that's correct, this could resolve some other bugs for when anytime the requested doc does not exist.

This comment has been minimized.

Copy link
@javanna

javanna Aug 1, 2014

Member

Makes sense, then I would add a specific Java test for it and create a separate issue marked as bug for it? Or maybe just adapt the title and label of this one, cause it seems that we already return the proper boolean flag but we might break trying to do that?

This comment has been minimized.

Copy link
@javanna

javanna Aug 1, 2014

Member

Actually, looking at the original issue (not the PR) everything is clearer, I would just mark it as a bug then.

This comment has been minimized.

Copy link
@javanna

javanna Aug 1, 2014

Member

But still, a Java test would be fantastic to have around this :)

@jpountz

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2014

It would also be nice to mention in the docs that this is a near realtime API and that term vectors are not available until the next refresh.

@jpountz

This comment has been minimized.

Copy link
Contributor

commented Aug 4, 2014

LGTM

@jpountz jpountz removed the review label Aug 4, 2014

@alexksikes alexksikes closed this Aug 21, 2014

@clintongormley clintongormley changed the title Term vector API: return found: false for docs between index and refresh Term Vectors: Return found: false for docs requested between index and refresh Sep 8, 2014

@clintongormley clintongormley changed the title Term Vectors: Return found: false for docs requested between index and refresh Return found: false for docs requested between index and refresh Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.