Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Added custom transport client settings to test infra #7129

Conversation

Projects
None yet
3 participants
@uboness
Copy link
Contributor

uboness commented Aug 1, 2014

It's now possible to define the additional customesettings for transport clients by extending transportClientSettings callback method on ElasticsearchIntegrationTest.

@jpountz

View changes

src/test/java/org/elasticsearch/test/InternalTestCluster.java Outdated
if (settings == null || settings == EMPTY) {
return SNIFF_CLIENT_FACTORY;
}
return new TransportClientFactory(true, settings);

This comment has been minimized.

Copy link
@jpountz

jpountz Aug 4, 2014

Contributor

Would settings.names().isEmpty() be cleaner than settings == EMPTY?

This comment has been minimized.

Copy link
@uboness

uboness Aug 4, 2014

Author Contributor

fair enough

@jpountz

This comment has been minimized.

Copy link
Contributor

jpountz commented Aug 4, 2014

Left one minor comment but other than that LGTM

@jpountz jpountz removed the review label Aug 4, 2014

Added custom transport client settings to test infra
It's now possible to define the additional customesettings for transport clients by extending `transportClientSettings` callback method on `ElasticsearchIntegrationTest`.
@uboness

This comment has been minimized.

Copy link
Contributor Author

uboness commented Aug 4, 2014

@jpountz updated

@uboness

This comment has been minimized.

Copy link
Contributor Author

uboness commented Aug 5, 2014

merged in 0da5cec

@uboness uboness closed this Aug 5, 2014

@clintongormley clintongormley changed the title Added custom transport client settings to test infra Test: Added custom transport client settings to test infra Sep 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.