Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "default" for tcpNoDelay and tcpKeepAlive #7136

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@kimchy
Copy link
Member

kimchy commented Aug 2, 2014

Allow to set the value default to network.tcp.no_delay and network.tcp.keep_alive so they won't be set at all, since on solaris, setting tcpNoDelay can actually cause failure
relates to #7115

Support "default" for tcpNoDelay and tcpKeepAlive
Allow to set the value default to network.tcp.no_delay and network.tcp.keep_alive so they won't be set at all, since on solaris, setting tcpNoDelay can actually cause failure
relates to #7115

@kimchy kimchy added review labels Aug 2, 2014

@rmuir

This comment has been minimized.

Copy link
Contributor

rmuir commented Aug 2, 2014

looks good.

@kimchy

This comment has been minimized.

Copy link
Member Author

kimchy commented Aug 2, 2014

pushed

@kimchy kimchy closed this Aug 2, 2014

@spinscale spinscale changed the title Support "default" for tcpNoDelay and tcpKeepAlive Netty: Support "default" for tcpNoDelay and tcpKeepAlive Aug 4, 2014

@jpountz jpountz removed the review label Aug 11, 2014

@kimchy kimchy deleted the kimchy:default_tcp_no_delay branch Aug 18, 2014

@clintongormley clintongormley changed the title Netty: Support "default" for tcpNoDelay and tcpKeepAlive Internal: Support "default" for tcpNoDelay and tcpKeepAlive Sep 8, 2014

@clintongormley clintongormley changed the title Internal: Support "default" for tcpNoDelay and tcpKeepAlive Support "default" for tcpNoDelay and tcpKeepAlive Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.