Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a request level flag to control Query Cache #7167

Merged
merged 1 commit into from Aug 5, 2014

Conversation

Projects
None yet
3 participants
@kimchy
Copy link
Member

kimchy commented Aug 5, 2014

A request level flag, defaults to be unset, to control the query cache. When not set, it defaults to the index level settings, when explicitly set, will override the index level setting

[Query Cache] Add a request level flag to control query cache
A request level flag, defaults to be unset, to control the query cache. When not set, it defaults to the index level settings, when explicitly set, will override the index level setting
closes #7167

@kimchy kimchy added review labels Aug 5, 2014

@@ -137,6 +137,8 @@ public MultiSearchRequest add(BytesReference data, boolean contentUnsafe, @Nulla
searchRequest.types(Strings.splitStringByCommaToArray(parser.text()));
} else if ("search_type".equals(currentFieldName) || "searchType".equals(currentFieldName)) {
searchRequest.searchType(parser.text());
} else if ("query_cache".equals(currentFieldName) || "queryCache".equals(currentFieldName)) {

This comment has been minimized.

Copy link
@jpountz

jpountz Aug 5, 2014

Contributor

I tend to like migrating such code to ParseFied when adding features. It avoids typos in the camelcase name that wouldn't be caught by tests for example

@jpountz

This comment has been minimized.

Copy link
Contributor

jpountz commented Aug 5, 2014

LGTM

@jpountz jpountz removed the review label Aug 5, 2014

@kimchy kimchy merged commit e6e2781 into elastic:master Aug 5, 2014

kimchy added a commit that referenced this pull request Aug 5, 2014

[Query Cache] Add a request level flag to control query cache
A request level flag, defaults to be unset, to control the query cache. When not set, it defaults to the index level settings, when explicitly set, will override the index level setting
closes #7167

@kimchy kimchy deleted the kimchy:query_cache_request_flag branch Aug 5, 2014

clintongormley added a commit that referenced this pull request Aug 6, 2014

clintongormley added a commit that referenced this pull request Aug 6, 2014

clintongormley added a commit that referenced this pull request Aug 6, 2014

clintongormley added a commit that referenced this pull request Aug 6, 2014

kimchy added a commit that referenced this pull request Sep 8, 2014

[Query Cache] Add a request level flag to control query cache
A request level flag, defaults to be unset, to control the query cache. When not set, it defaults to the index level settings, when explicitly set, will override the index level setting
closes #7167

clintongormley added a commit that referenced this pull request Sep 8, 2014

clintongormley added a commit that referenced this pull request Sep 8, 2014

@clintongormley clintongormley changed the title [Query Cache] Add a request level flag to control query cache Query Cache: Add a request level flag to control query cache Sep 8, 2014

@clintongormley clintongormley changed the title Query Cache: Add a request level flag to control query cache Add a request level flag to control Query Cache Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.